Showing
2 changed files
with
7 additions
and
10 deletions
| ... | @@ -4,8 +4,6 @@ namespace BookStack\Http\Middleware; | ... | @@ -4,8 +4,6 @@ namespace BookStack\Http\Middleware; |
| 4 | 4 | ||
| 5 | use Closure; | 5 | use Closure; |
| 6 | use Illuminate\Contracts\Auth\Guard; | 6 | use Illuminate\Contracts\Auth\Guard; |
| 7 | -use BookStack\Exceptions\UserRegistrationException; | ||
| 8 | -use Setting; | ||
| 9 | 7 | ||
| 10 | class Authenticate | 8 | class Authenticate |
| 11 | { | 9 | { | ... | ... |
| ... | @@ -5,9 +5,7 @@ use BookStack\View; | ... | @@ -5,9 +5,7 @@ use BookStack\View; |
| 5 | 5 | ||
| 6 | class ViewService | 6 | class ViewService |
| 7 | { | 7 | { |
| 8 | - | ||
| 9 | protected $view; | 8 | protected $view; |
| 10 | - protected $user; | ||
| 11 | protected $permissionService; | 9 | protected $permissionService; |
| 12 | 10 | ||
| 13 | /** | 11 | /** |
| ... | @@ -18,7 +16,6 @@ class ViewService | ... | @@ -18,7 +16,6 @@ class ViewService |
| 18 | public function __construct(View $view, PermissionService $permissionService) | 16 | public function __construct(View $view, PermissionService $permissionService) |
| 19 | { | 17 | { |
| 20 | $this->view = $view; | 18 | $this->view = $view; |
| 21 | - $this->user = user(); | ||
| 22 | $this->permissionService = $permissionService; | 19 | $this->permissionService = $permissionService; |
| 23 | } | 20 | } |
| 24 | 21 | ||
| ... | @@ -29,8 +26,9 @@ class ViewService | ... | @@ -29,8 +26,9 @@ class ViewService |
| 29 | */ | 26 | */ |
| 30 | public function add(Entity $entity) | 27 | public function add(Entity $entity) |
| 31 | { | 28 | { |
| 32 | - if ($this->user === null) return 0; | 29 | + $user = user(); |
| 33 | - $view = $entity->views()->where('user_id', '=', $this->user->id)->first(); | 30 | + if ($user === null || $user->isDefault()) return 0; |
| 31 | + $view = $entity->views()->where('user_id', '=', $user->id)->first(); | ||
| 34 | // Add view if model exists | 32 | // Add view if model exists |
| 35 | if ($view) { | 33 | if ($view) { |
| 36 | $view->increment('views'); | 34 | $view->increment('views'); |
| ... | @@ -39,7 +37,7 @@ class ViewService | ... | @@ -39,7 +37,7 @@ class ViewService |
| 39 | 37 | ||
| 40 | // Otherwise create new view count | 38 | // Otherwise create new view count |
| 41 | $entity->views()->save($this->view->create([ | 39 | $entity->views()->save($this->view->create([ |
| 42 | - 'user_id' => $this->user->id, | 40 | + 'user_id' => user()->id, |
| 43 | 'views' => 1 | 41 | 'views' => 1 |
| 44 | ])); | 42 | ])); |
| 45 | 43 | ||
| ... | @@ -78,13 +76,14 @@ class ViewService | ... | @@ -78,13 +76,14 @@ class ViewService |
| 78 | */ | 76 | */ |
| 79 | public function getUserRecentlyViewed($count = 10, $page = 0, $filterModel = false) | 77 | public function getUserRecentlyViewed($count = 10, $page = 0, $filterModel = false) |
| 80 | { | 78 | { |
| 81 | - if ($this->user === null) return collect(); | 79 | + $user = user(); |
| 80 | + if ($user === null || $user->isDefault()) return collect(); | ||
| 82 | 81 | ||
| 83 | $query = $this->permissionService | 82 | $query = $this->permissionService |
| 84 | ->filterRestrictedEntityRelations($this->view, 'views', 'viewable_id', 'viewable_type'); | 83 | ->filterRestrictedEntityRelations($this->view, 'views', 'viewable_id', 'viewable_type'); |
| 85 | 84 | ||
| 86 | if ($filterModel) $query = $query->where('viewable_type', '=', get_class($filterModel)); | 85 | if ($filterModel) $query = $query->where('viewable_type', '=', get_class($filterModel)); |
| 87 | - $query = $query->where('user_id', '=', user()->id); | 86 | + $query = $query->where('user_id', '=', $user->id); |
| 88 | 87 | ||
| 89 | $viewables = $query->with('viewable')->orderBy('updated_at', 'desc') | 88 | $viewables = $query->with('viewable')->orderBy('updated_at', 'desc') |
| 90 | ->skip($count * $page)->take($count)->get()->pluck('viewable'); | 89 | ->skip($count * $page)->take($count)->get()->pluck('viewable'); | ... | ... |
-
Please register or sign in to post a comment